Skip to content

Get search on dynamic groups working (temp hack) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rom1-B merged 4 commits into from
Nov 18, 2025
Merged

Get search on dynamic groups working (temp hack) #90

Rom1-B merged 4 commits into from
Nov 18, 2025

Conversation

@stonebuzz
Copy link
Contributor

@stonebuzz stonebuzz commented Nov 18, 2025 •
edited by Rom1-B
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

To store dynamic groups search criteria, we need a submit button, see glpi-project/glpi#20731

same as glpi-project/glpi-inventory-plugin#731

Screenshots (if appropriate):

@stonebuzz stonebuzz requested a review from trasher November 18, 2025 10:33
@stonebuzz stonebuzz self-assigned this Nov 18, 2025
@stonebuzz stonebuzz added the bug Something isn't working label Nov 18, 2025
@trasher
Copy link
Contributor

trasher commented Nov 18, 2025

Please fix rector issues

@stonebuzz stonebuzz requested a review from Rom1-B November 18, 2025 13:13
@Rom1-B Rom1-B merged commit 09fbdcd into main Nov 18, 2025
3 checks passed
@Rom1-B Rom1-B deleted the fix_btn branch November 18, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trasher trasher trasher approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@stonebuzz stonebuzz

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stonebuzz @trasher @Rom1-B